adafruit / Adafruit_CircuitPython_RGB_Display

Drivers for RGB displays for Adafruit CircuitPython.
MIT License
131 stars 52 forks source link

make numpy speed improvements more prominent #64

Closed philippkeller closed 4 years ago

philippkeller commented 4 years ago

Following up on ladyadas comment I tried to make numpy's speed improvement more prominent.

That's how I approach that. Of course this could be solved in other ways, some alternatives I considered:

ladyada commented 4 years ago

hi - please dont do it this way - have the gif loader example import numpy, that will force it to be installed :)

philippkeller commented 4 years ago

hi - please dont do it this way - have the gif loader example import numpy, that will force it to be installed :)

I'm confused. So you mean add import numpy in the first line of the image() method? And then also remove the code which handles the case when numpy is not available?

ladyada commented 4 years ago

no to the gif loader example, the python script

philippkeller commented 4 years ago

oh, I was totally on another track :-) the thread was referring the gif example. But I didn't look at the example yet (rotating gif is not my use case).

Now I understand what you mean. I'll close this PR and I will later open another one with:

Also I think the examples could be put more prominently in readme, maybe I'll add a suggestion in the same PR

ladyada commented 4 years ago

awesome, sounds good :)