search

adafruit / Adafruit_CircuitPython_RGB_Display

Drivers for RGB displays for Adafruit CircuitPython.
MIT License
131 stars 52 forks source link

Add text #67

Closed TG-Techie closed 4 years ago

TG-Techie commented 4 years ago

add text support to the library in a fast manner

work in progress pylint wise, but I put it up here for review/suggestion and food for thought

the text function could really be broken into more parts, I just figured it would be better to get it working (it's just long, for now ). also added scaling into _block so the scaling feature wasn't limited text

FoamyGuy commented 4 years ago

I tested this out starting from the sample code from here with a Feather M4 Express + 2.4" TFT Featherwing.

I am getting this error from the sample code when I switch to this version of the library: 

  File "/lib/adafruit_rgb_display/ili9341.py", line 94, in __init__
  File "/lib/adafruit_rgb_display/rgb.py", line 568, in __init__
  File "/lib/adafruit_rgb_display/rgb.py", line 163, in __init__
  File "/lib/adafruit_rgb_display/rgb.py", line 618, in rotation
Exception: rotation not currently supported for this display, see datasheet
kattni commented 4 years ago

@TG-Techie Please let me know if this is something you're still interested in working on. If I don't hear from you, I'll close the PR for now. It can be reopened, and none of your local work is affected by the PR being closed. If at a future time you are interested in picking it up again and it has been closed, let me know and I can reopen it.

kattni commented 4 years ago

Closing for now.