search

adafruit / Adafruit_CircuitPython_Requests

Requests-like interface for web interfacing
MIT License
51 stars 36 forks source link

typing.Protocol requires Python 3.8+ #106

Closed tekktrik closed 2 years ago

tekktrik commented 2 years ago

I haven't tested this, but since there is no alternative use of typing_extensions.Protocol, there many be issues where Blinka is running on 3,7 and cannot use this library, correct?

dhalbert commented 2 years ago

typing_extensions is backported to 3.7, so as long as it gets imported at some point, it should be OK?

tekktrik commented 2 years ago

Okay, I can work it in

dhalbert commented 2 years ago

that is, you could try to import Protocol from typing, and if it fails, import it from typing_extensions. But you've seen that before, I'm pretty sure.

tekktrik commented 2 years ago

Alright, I re-purposed #107 to solve this since it was just appeasing the formatter anyways!