search

adafruit / Adafruit_CircuitPython_Requests

Requests-like interface for web interfacing
MIT License
51 stars 37 forks source link

Move typing annotation definitions to `circuitpython_typing` #113

Closed tekktrik closed 6 months ago

tekktrik commented 2 years ago

This library may improve from having some of the type annotations reworked and checked, as well as moved to circuitpython_typing. This might improve readability of the library.

dhalbert commented 2 years ago

I have a branch where I started to do this: https://github.com/adafruit/Adafruit_CircuitPython_Requests/compare/main...dhalbert:Adafruit_CircuitPython_Requests:change-exceptions

justmobilize commented 6 months ago

@dhalbert can this be closed? The typing is in adafruit_typing and I removed it from here, and then connection_manager once I saw it in the typing lib

dhalbert commented 6 months ago

Fixed by https://github.com/adafruit/Adafruit_CircuitPython_Typing/pull/35, I think.