DJDevon3
commented
7 months ago I've changed syntax to with requests.get(DATA_SOURCE) as owm_request and still getting some kind of socket leak. Here's my serial output. After 3 days it errored with an AdafruitIO error. Currently if that error is detected it does a supervisor.reload which frees everything up again and will work for a couple hours or days but will eventually error again.
===============================
Board Uptime: 3.2 days
Temp: 81.8681
Actual Temp: 81.1
| Connecting to WiFi...
| ✅ WiFi!
| | Attempting to GET Weather!
| | Account within Request Limit
| | ✅ Connected to OpenWeatherMap
| | | Sunrise: 06:50
| | | Sunset: 17:27
| | | Temp: 84.61
| | | Pressure: 1011
| | | Humidity: 68
| | | Weather Type: Clear
| | | Wind Speed: 10.36
| | | Timestamp: 2023/11/26 15:05
| | ✂️ Disconnected from OpenWeatherMap
| | ❌ AdafruitIO_MQTTError:
MQTT Error: Unable to connect to Adafruit IO.
Code done running.
soft reboot
anecdata
Circuit Python 8.2.7, Adafruit Feather ESP32-S3 I've tracked down a weird syntax issue that caused me a lot of headache.
I believe I got that syntax from Neradoc or Deshipu a long time ago and I've been using it ever since in my personal projects. It only reduces the code by 1 line but it worked... until 8.2.7 where it exposed a potential bug when my script starting failing in unexpected ways completely deviating from its past stable behavior.
As RimWolf & Anecdata have pointed out the correct way is
Above method "should" automatically close the response and seems to work ok. or
Above method
with requestswill close a socket automatically so response.close() is unneeded but you can still use it explicitly if you want.The problem that cropped up is if you use
response = requests.get(DATA_SOURCE).json()it will slowly leak sockets failing to close them. It will work fine for hours and even days at a time but will eventually fail to close a socket properly which will end up with a -2 gaierror and/orThe culprit is
response = requests.get(DATA_SOURCE).json()is valid syntax and does not cause an error but will 100% eventually fail. I've gone as long as 4 days without encountering that error but it will happen eventually. This syntax seems to work on the surface at first but also makes using response.close() impossible due to a dict error.This issue is related to OSError -2 gaierror and RuntimeError: Out of sockets.
I modified my requests script to use the default way as Rimwolf & Anecdata advised and have not had a gaierror, sending request error, or socket error since. The biggest problem with tracking this one down is how randomly intermittent it is. It could take days or weeks depending on your polling rate. My polling rate is typically 15 minutes.
I think this is a syntax issue as requests wants things in a specific way. If you deviate from the norm it will not complain about the syntax and instead will start throwing random errors. There are a lot of response.close() open issues and I'm not sure where this one fits. Just wanted to share my experience fighting against it for weeks trying to track down the gaierror which eventually led to this.