search

adafruit / Adafruit_CircuitPython_Requests

Requests-like interface for web interfacing
MIT License
51 stars 36 forks source link

Fix examples for ESP32SPI + SSL socket #58

Closed brentru closed 3 years ago

brentru commented 3 years ago

Addresses https://github.com/adafruit/Adafruit_CircuitPython_Requests/issues/57 and fixes RuntimeError: Cannot access content after getting text or json error in examples/requests_advanced.py

anecdata commented 3 years ago

Tested examples/requests_simpletest.py & examples/requests_advanced.py on PyPortal with 6.1.0-beta.2 and other libraries from 20201225. Also tested HTTPS. Looks good.

brentru commented 3 years ago

@anecdata sorry for the re-ping, thought i requested circuitpython librarians as a reviewer. Could you please re-review? Thanks

anecdata commented 3 years ago

@brentru I'm kinda new to circuitpythonlibrarians ...what's the etiquette here: who merges? who releases?

brentru commented 3 years ago

@anecdata In my experience, CircuitPython Librarians generally review and merge/release (or @dherrada sometimes releases, I do not know the full process here) if the original PR author doesn't have access to the repo.