search

adafruit / Adafruit_CircuitPython_Requests

Requests-like interface for web interfacing
MIT License
51 stars 36 forks source link

Update requests_https_cpython.py #59

Closed jfabernathy closed 3 years ago

jfabernathy commented 3 years ago

found some missing calls to fix he socket

tannewt commented 3 years ago

@jfabernathy Want to move this into a separate example still?

jfabernathy commented 3 years ago

I'm not sure what you are asking. I'm really confused about git hub and the whole process that it includes except for cloning repositories . I was asked to create a pull request and I did having no idea what that meant or entailed. I think, if memory serves, I posted this example on the Adafruit Forum after I got help over there. I've been confused ever since.

tannewt commented 3 years ago

@jfabernathy In this PR you've edited the requests_https_cpython.py file so it works on CircuitPython. That is a useful example to have but we also want the example for CPython (normal desktop python). So, the edited version should be added as a new file to leave the cpython one as-is.

For GitHub background I recommend this guide: https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github

jfabernathy commented 3 years ago

So how do we delete this pull request so the original file is undisturbed? I'll work on a new example when I can. I still don't know how I ended up on a Desktop example instead of a circuitpython example

jfabernathy commented 3 years ago

on my copy of my example I've changed the comment from Cpython to circuitpython and I'm studying the guide on how to post an example to github. I'll try to do that soon, but figuring out how github works is harder than writing Intel 386 assembler.

tannewt commented 3 years ago

I'll close this. I think you should be able to do "Add file" in the top right-ish of this page: https://github.com/adafruit/Adafruit_CircuitPython_Requests/tree/master/examples