search

adafruit / Adafruit_CircuitPython_Requests

Requests-like interface for web interfacing
MIT License
51 stars 36 forks source link

Fixes #48 #76

Closed askpatrickw closed 3 years ago

askpatrickw commented 3 years ago

Fixes #48 Adds airlift config to example, and some HTTPS alongside the HTTP Fixes all the pylint errors on the tests and breaks out the tests into their own pre-commit step to deal with duplicate code.

I am fixing this because the current Azure IOT examples using ESP32SPI connectivity fail without it.

@tannewt I have a question about my fix though as it also gives a pylint error

adafruit_requests.py:656:57:
W0212: Access to a protected member _the_interface of a client class (protected-access)

Am I misunderstanding your suggested fix in #48 ?

tannewt commented 3 years ago

Thanks @askpatrickw it looks good! Just disable pylint for the protected access.

askpatrickw commented 3 years ago

Thanks @tannewt I just wanted to be sure.

ladyada commented 3 years ago

fyi @brentru as well