adafruit / Adafruit_CircuitPython_Requests

Requests-like interface for web interfacing
MIT License
51 stars 36 forks source link

Connection failure when using non-standard HTTP port #90

Open TheRealMintd opened 2 years ago

TheRealMintd commented 2 years ago

To start, I'm using this library along with the adafruit_espatcontrol library. When using a URL such as http://example.com:8000/, the error RuntimeError: Connection type must be TCP, UDL or SSL is raised.

I think this happens because the conntype parameter is left empty during the _get_socket call, which results in the socket determining the type of the connection based on the port alone.

Since this library knows whether the request is using HTTP or HTTPS, maybe the conntype can be passed directly to the function based on that. ~Unfortunately, the adafruit_esp32spi library seems to use a completely different way of describing the conntype, which might make passing it problematic.~