Closed rpavlik closed 3 years ago
Would you mind adding co2 to the design guide listing too? https://github.com/adafruit/circuitpython/blob/main/docs/design_guide.rst#sensor-properties-and-units Thanks!
I see that TVOC is in all caps. Do we want CO2
in all caps too? or lowercase like most of the rest?
CO2 is a technical spelling, i'd prefer its in all caps
OK, I'll revise this accordingly.
thank you :)
OK, commits updated, and the docs PR is here: https://github.com/adafruit/circuitpython/pull/4070
thanks, gonna wait till @tannewt is around and approves the new 'sensor type'
This is a real CO2 sensor, so the docs and API should reflect that - see recent equivalent change to the arduino library. I opted to lowercase the property name now that we don't need mixed case to distinguish "e" from "CO2", so scd30.eCO2 is now just scd30.co2.
I also fixed some typos I saw as I was going thru.
Fixes #4