Closed caternuson closed 2 years ago
This is a minor big. The mask here should be removed: https://github.com/adafruit/Adafruit_CircuitPython_SI1145/blob/4b44479fe55e5d479b77ece46478ae04c1afe2a7/adafruit_si1145.py#L165
Masking the upper 4 bits is useful to detect if there is an error. But the actual error is then coded into the lower 4 bits. So the print should just not mask anything and print the whole response value.
I would like to help.
sokratisvas
commented
2 years ago
This is a minor big. The mask here should be removed: https://github.com/adafruit/Adafruit_CircuitPython_SI1145/blob/4b44479fe55e5d479b77ece46478ae04c1afe2a7/adafruit_si1145.py#L165
Masking the upper 4 bits is useful to detect if there is an error. But the actual error is then coded into the lower 4 bits. So the print should just not mask anything and print the whole response value.