search

adafruit / Adafruit_CircuitPython_SSD1327

DisplayIO drivers for grayscale OLEDs driven by SSD1327
MIT License
3 stars 7 forks source link

resolves #13 Missing Type Annotations #16

Closed tcfranks closed 2 years ago

tcfranks commented 2 years ago

submitted for review/comment:

I went a little further here and added the kwargs to the docstring. Also, if rotation is triggered the action is raising questions in my mind compared to the spi devices I did prior:

    if "rotation" in kwargs and kwargs["rotation"] % 180 != 0:
        height = kwargs["width"]

This is just setting height = width. Shouldn't it also set width = height to make a complete rotation of 90 deg?

tcfranks commented 2 years ago

the most recent commit was to do the kwargs