Add explicit pin directions to examples

adafruit / Adafruit_CircuitPython_TinyLoRa

Adafruit Tiny LoRa

MIT License

44 stars 45 forks source link

Add explicit pin directions to examples #13

Closed brentru closed 5 years ago

brentru commented 5 years ago

While digitalio defaults to input, it's very important for the IRQ and CS pins to be set as inputs, IRQ is expected to be pulled up at the end of the send_packet() method.

Patch:

Adding explicit pin directions to examples in case the default changes and for clarity.

jerryneedell commented 5 years ago

CS is an output IRQ is an input

jerryneedell commented 5 years ago

I'd rather see IRQ set to INPUT in adafruit_tinylora.py. The user just provides the pins

brentru commented 5 years ago

I've set the irq as input and cs as output from the driver instead of the example, added self._cs as well, passed into the bus device, removed directions in examples/