search

adafruit / Adafruit_CircuitPython_Typing

Definitions not in the standard `typing` module that are needed for type annotation of CircuitPython code.
MIT License
6 stars 9 forks source link

mpy zips don't contain mpy files #34

Closed FoamyGuy closed 9 months ago

FoamyGuy commented 1 year ago

The assets on the release page that are supposed to contain mpy files for the library don't actually contain library files. Instead they contain only the examples:

image

This library is not typically used on devices so it's unlikely many people would be looking for it there, I guess that is why it has gone undiscovered.

I ran across a need to put it on a device to check something and noticed I'm unable to install it circup or grab the mpy files manually from the release assets.

Neradoc commented 1 year ago

The absence of the mpy files seems to be due to a bug in the new action thing, where packages without the adafruit_ prefix are ignored. I'll open an issue for that.

_EDIT: maybe it's not a bug in the action, but a missing parameter in this repo's action. (see https://github.com/adafruit/Adafruit_CircuitPython_asyncio/pull/41 )_

However, I believe the fix here is simply to disable the workflow that creates those zips. This library should not be used on devices, its absence MUST trigger the except clause in libraries that try to import it.

In fact it can't be run in CP (because of requirements) or even compiled with mpy-cross:

❯ mpy-cross circuitpython_typing/io.py 
Traceback (most recent call last):
  File "circuitpython_typing/io.py", line 43
SyntaxError: invalid syntax
tekktrik commented 1 year ago

I can add a disabling input for the workflow, I agree that makes the most sense. It should only disable .mpy zip(s), right?

tekktrik commented 1 year ago

Alright, ready to make a PR for this!