search

adafruit / Adafruit_CircuitPython_Waveform

CircuitPython library to generate single wavelength waveforms.
MIT License
7 stars 13 forks source link

Add Adafruit-Blinka to requirements #8

Closed evaherrada closed 5 years ago

sommersoft commented 5 years ago

Does this actually need Blinka? Its just a couple functions returning an array of waveforms...

If Blinka is being added solely because the library is on PyPI, then might as well add it to the setup.py: https://github.com/adafruit/Adafruit_CircuitPython_Waveform/blob/master/setup.py#L37

evaherrada commented 5 years ago

I’m no really sure. I was just basing this off of it being on the contributing page on the circuitpython website under the list of things that were missing adafruit-blinka as a requirement.

makermelissa commented 5 years ago

6 was a PR for the same thing and it was closed because it was determined that this wasn't needed. Can we put this on an Adabot ignore list so it doesn't show up as something that needs to be done?

evaherrada commented 5 years ago

That’d probably be good. I can try to look into that but I’m very unfamiliar with adabot.

sommersoft commented 5 years ago

Can we put this on an Adabot ignore list

Funny thing... I was just working on Adabot and noticed that it was already added to the ignore list. 🌮s all around! 😄

makermelissa commented 5 years ago

Is the Adabot ignore list not working then?

sommersoft commented 5 years ago

I'll be able to verify in a few; I have it running now. I was running a specific validator which doesn't use the LIBRAIRES_DONT_NEED_BLINKA list.

evaherrada commented 5 years ago

It is now but it wasn’t when I made the PR a few weeks ago.

sommersoft commented 5 years ago

I think it was done during PyCon. I know it was something that came up before (PyCon18, perhaps). but the conversation had a long break...

makermelissa commented 5 years ago

Ok, cool.

makermelissa commented 5 years ago

I think it was PyCascades that the conversation last came up. Possibly during PyCon18 too, but I wasn’t around then.

sommersoft commented 5 years ago

Yeah, PyCascades seems more likely. The Issue was opened in Feb. 😉