adafruit / Adafruit_CircuitPython_Wiznet5k

Pure-Python interface for WIZNET 5k Ethernet modules
Other
15 stars 35 forks source link

Reset pin is not configured as an output #124

Closed fasteddy516 closed 12 months ago

fasteddy516 commented 1 year ago

In WIZNET5K.__init__() the optional reset pin is not configured as an output before it is written to, which means that has to be done elsewhere in code prior to driver instantiation. It's not a big deal, but is different from how the CS pin - which has switch_to_output() called on it before it is used - is handled.

Is there any reason not to add a call to reset.switch_to_output() within the driver?

(I don't mind doing a pull request for it if that helps - I'm pretty sure it's just a one-liner.)