Ignore last 2 bits of digital input, only on boards without long ints

adafruit / Adafruit_CircuitPython_seesaw

seesaw helper IC driver for circuitPython

MIT License

60 stars 35 forks source link

Ignore last 2 bits of digital input, only on boards without long ints #108

Closed carlfj closed 2 years ago

carlfj commented 2 years ago

For compatibility on boards that don't support arbitrary integers. Bit 31 and 32 are scrubbed on these boards instead of throwing OverflowError, while builds with long ints retain this extra functionality.

Previous version breaks functionality for boards like QT Py SAMD21 using NeoKey 1x4 QT I2C Breakout or ATSAMD09 Breakout with Seesaw. More details in comments of issue #107.

Closes: #107

jepler commented 2 years ago

Thank you! I updated the description of this PR to reflect that it closes the referenced bug.