adafruit / Adafruit_CircuitPython_seesaw

seesaw helper IC driver for circuitPython
MIT License
60 stars 35 forks source link

add support for different chip detection + quad rotary demo #118

Closed ladyada closed 1 year ago

ladyada commented 1 year ago

@BlitzCityDIY will need linting n stuffs but is tested on a feather m4

BlitzCityDIY commented 1 year ago

@ladyada thanks! i ran pylint for the example but i wanted to check on an error in seesaw.py in the analog_read and analog_write functions:

seesaw.py:268:27: E0602: Undefined variable '_ATTINY8X7_HW_ID_CODE' (undefined-variable)
seesaw.py:364:27: E0602: Undefined variable '_ATTINY8X7_HW_ID_CODE' (undefined-variable)

i wasn't sure if the variable was maybe supposed to be _ATTINY807_HW_ID_CODE or _ATTINY817_HW_ID_CODE?

ladyada commented 1 year ago

@BlitzCityDIY ok i think if ixed that error, only the samd09 has weird offsets. now we just use the native pin names

caternuson commented 1 year ago

@ladyada OK, now it's just black (like clangformat, just run it and let it do what it wants) and pylint (fix or shush, etc).

ladyada commented 1 year ago

@BlitzCityDIY can you do the 🧹 - im getting roped into show stuff :)

ladyada commented 1 year ago

thanks all :)