search

adafruit / Adafruit_DotStar

GNU General Public License v3.0
98 stars 58 forks source link

Define "Color" method as static #18

Closed yngndrw closed 2 years ago

yngndrw commented 7 years ago

The "Color" helper method should be defined as static as it does not use any member variables: https://github.com/adafruit/Adafruit_DotStar/blob/master/Adafruit_DotStar.h#L56 https://github.com/adafruit/Adafruit_DotStar/blob/master/Adafruit_DotStar.cpp#L306

This would also match the definition within the NeoPixel library: https://github.com/adafruit/Adafruit_NeoPixel/blob/master/Adafruit_NeoPixel.h#L143

Also it should be spelt "Colour". :)

yngndrw commented 7 years ago

See PR #21.

caternuson commented 2 years ago

Closing. Looks like this was taken care of at some point in another PR or commit.