adafruit / Adafruit_DotStar

GNU General Public License v3.0
97 stars 58 forks source link

REQ: Please Add Support For MKR-RGB and Portenta H7 #40

Closed jwestmoreland closed 2 years ago

jwestmoreland commented 3 years ago

Note - example in DotStarMatrix will demonstrate the changes - so, this in addition to the PR in the DotStarMatrix PR are necessary.

REQ: Please Add Support for the MRK-RGB Shield and the Portenta_H7. A jumper must be placed from A3->A5 when using the MRK-RGB shield on the Portenta H7.

List of changes: The MRK-RGB shield has to used in 'bit-bang' mode to work on the Portenta H7 and one jumper must be added - the A3 pin must be jumpered to A5. It's a relatively easy change to be able to use the shield on the H7. Yes, it's a one-off but I must admit I like to use that shield on the H7. And, you can't have too many graphics libs, right?

In Adafruit_Dotstar.h: added:

define PORTENTA_H7 // STM32H747xI

In Adafruit_Dotstar.cpp: added:

ifndef PORTENTA_H7 'wrapper' to force use of software spi (a.k.a. bit-bang mode).

Readme.md: Updated to summarize changes made.

To run as-is (before this update) - just comment out the

define PORTENTA_H7 // STM32H747xI

in Adafruit_Dotstar.h.

This update is also demonstrated in a subsequent PR in the Adafruit_DotStarMatrix library: ..\examples\dotstar_wing\dotstar_win.ino has been updated to allow use of the MKR-RGB shield on the Portenta H7. The associated PR is here: https://github.com/adafruit/Adafruit_DotStarMatrix/pull/6

jwestmoreland commented 3 years ago

clang fails:

if defined(__AVR_ATtiny85__)

[error]Process completed with exit code 1.

I wonder if this issue is somewhat related to what is mentioned here:

jwestmoreland commented 3 years ago

Hello AdaFruit,

This works on my set up - not sure why this is failing. The clang issue is ambiguous at best.

I have to think what's outlined here is similar possibly to what's going on:

https://github.com/actions/virtual-environments/issues/1279

Does this have anything to do with the workflow for checking PR's?

Thanks In Advance, John W.

ladyada commented 3 years ago

you can run clang-format -i on files that are failing to format them

jwestmoreland commented 3 years ago

Hello @ladyada,

OK - hopefully I've fixed that - and trying now.

Thanks! John W.

caternuson commented 2 years ago

This is hopefully fixed a different way via #47. Please try the 1.2.0 (or newer) library release.