search

adafruit / Adafruit_DotStar

GNU General Public License v3.0
97 stars 58 forks source link

Add Gemma M0 on board example #45

Closed caternuson closed 2 years ago

caternuson commented 2 years ago

For #35. Adds a new dedicated Gemma M0 example for DotStar. The idea of using #defs is good, but would need to update several board headers to add and also would change name of existing example.

Tested on Gemma M0.

ladyada commented 2 years ago

i think the itsybitsy m0 and m4 also have built in dotstar, wanna have one combo example for all 3?

caternuson commented 2 years ago

hmm...sure..watcha think? always a toss up on what's "easier"? a single example with commented out stuff for each board vs. a dedicated stand alone example for each.

if we want a single example, might be nice to do as suggested in #35 and add a consistent set of #defs like INTERNAL_DS_DATA and INTERNAL_DS_CLK?

It's there for GEMMA for example: https://github.com/adafruit/ArduinoCore-samd/blob/67dfb93a4a141a8ed76ddab9561100132a5dffe4/variants/gemma_m0/variant.h#L87-L89 but not others.

ladyada commented 2 years ago

that would be best, we do it now for neopixels - wanna do the PR for the dotstar-containing boards? Adafruit Trinket M0 Itsy Bitsy M0 Express Adafruit PyRuler FunHouse Adafruit ItsyBitsy nRF52840 Adafruit GEMMA M0 adafruit itsybitsy m4

caternuson commented 2 years ago

Sure. Simple update, added an issue for tracking: https://github.com/adafruit/ArduinoCore-samd/issues/320

Closing this. After updating the core, will make a new PR with a unified example.