search

adafruit / Adafruit_EPD

e-paper display driver for Arduino
140 stars 57 forks source link

FeatherWingTest drawBMP setting location not working #15

Closed caternuson closed 4 years ago

caternuson commented 4 years ago

Re this thread: https://forums.adafruit.com/viewtopic.php?f=57&t=159450

Maybe add the x,y offsets here? https://github.com/adafruit/Adafruit_EPD/blob/805921829fa7e812eb5ccbd134d99b50fb06050e/examples/FeatherWingTest/FeatherWingTest.ino#L234

ladyada commented 4 years ago

have them try https://github.com/adafruit/Adafruit_ImageReader ?

caternuson commented 4 years ago

@makermelissa does the FeatherWingTest example in this repo need updating as well? Or maybe just removed in favor of something in the ImageReader repo?

makermelissa commented 4 years ago

I think probably removed in favor of the ImageReader repo. I think the EInkBreakout example in the ImageReader repo should be able to do feathers as well, but I'd have to double check that.

ladyada commented 4 years ago

yah plz remove here - imagereader is our canonical image-to-display library!

caternuson commented 4 years ago

ok @makermelissa can you make that PR? since it sounds like maybe you want to test some things.

makermelissa commented 4 years ago

Yes, should be easy enough.

makermelissa commented 4 years ago

Ok, after looking at it, I'm going to make 2 PRs:

  1. Add a new EInkFeatherWing test to ImageReader so the breakout one doesn't get messy.
  2. Remove any examples in this library that draw bitmaps.
ladyada commented 4 years ago

sounds like a good plan!