search

adafruit / Adafruit_EPD

e-paper display driver for Arduino
140 stars 56 forks source link

Changed pins variable type from int8_t to int16_t. #62

Closed mirzafahad closed 2 years ago

mirzafahad commented 2 years ago

So that we can accommodate pin numbers greater than 128. Fixes #60.

ladyada commented 2 years ago

hiya! thanks so much for submitting a PR! we can review & merge PRs once they have passed continuous integration (CI). that means that code compiles cleanly for all tested platforms, is clang formatted so we maintain the same text formatting for all new code, and is doxygen documented. if your code isnt passing, check the CI output (click on the red X next to the PR to scroll through the log and find where the error is

here is a tutorial on doxygen: https://learn.adafruit.com/the-well-automated-arduino-library/doxygen

and clang-format: https://learn.adafruit.com/the-well-automated-arduino-library/formatting-with-clang-format

and overall how to contribute PRs to libraries: https://learn.adafruit.com/contribute-to-arduino-with-git-and-github

once you get that green checkmark that indicates CI has passed, please comment reply to this post so we know its time for another review (we may not get notified on CI pass and miss that its time to look!)

mirzafahad commented 2 years ago

Sorry, it took me a while to get back to this. But I have fixed the clang-format now.

ladyada commented 2 years ago

all good! epic changes, did you test this with hardware and if so, which? :)

mirzafahad commented 2 years ago

I tested it with "Adafruit Feather nRF52 Bluefruit LE - nRF52832" and a STM32Nucleo-L053R8.