Closed hathach closed 2 years ago
thank for the approval :smile:
LGTM.
This one seems a bit odd though
241 | buf[i] = (buf[i] << 1) | digitalRead(_miso);
Why is it complaining about c
, but flagging buf
?
it is due to the usage of read8(), used by most example sketch
which passed uninitialized variable 'c'. GCC becomes too smart, it now looks through the whole call-stack and it won't throw warnings if we actually initialize 'c'. Though it may warn if other read variant is used such as read16(). So I think we are better to fix this here.
come across these warnings when doing some work with nrf52.