Closed yilungao closed 2 years ago
hiya! thanks so much for submitting a PR! we can review & merge PRs once they have passed continuous integration (CI). that means that code compiles cleanly for all tested platforms, is clang formatted so we maintain the same text formatting for all new code, and is doxygen documented. if your code isnt passing, check the CI output (click on the red X next to the PR to scroll through the log and find where the error is
here is a tutorial on doxygen: https://learn.adafruit.com/the-well-automated-arduino-library/doxygen
and clang-format: https://learn.adafruit.com/the-well-automated-arduino-library/formatting-with-clang-format
and overall how to contribute PRs to libraries: https://learn.adafruit.com/contribute-to-arduino-with-git-and-github
once you get that green checkmark that indicates CI has passed, please comment reply to this post so we know its time for another review (we may not get notified on CI pass and miss that its time to look!)
this probably needs to wait a few days for new version of BusIO released. Since CI runs based on the released lib. Please be patient in the meanwhile
fix https://github.com/adafruit/Adafruit_FRAM_SPI/issues/25
Scope: added
const
keyword tovoid Adafruit_FRAM_SPI::write(uint32_t addr, const uint8_t *values, size_t count)
This change is dependent on the pull request on the underlying lib Adafruit_BusIO. Tested with ESP32 DevKitC (espressif) and the Adafruit SPI Non-Volatile FRAM Breakout - 64Kbit / 8KByte (MB85RS64V).
Thank you!