search

adafruit / Adafruit_FRAM_SPI

Driver for Adafruit's SPI-Based FRAM Breakouts
Other
35 stars 30 forks source link

Address range support for 24 and 32 bit FRAM SPI chips. #6

Closed pholmes2012 closed 6 years ago

pholmes2012 commented 7 years ago

  1. Added support for 3 and 4 byte addresses.

  2. Allow default manufacturer and product IDs. (0x7f, 0x7f7f)

  3. Added constructor that requires no parameters.

  4. Added begin(.) method that takes an address byte size parameter, if > 2

  5. Added begin(..) method that takes address byte size and CS pin parameter, for when the new zero parameter constructor is used.

  6. Added Particle Photon as a tested and working device.

  7. Added a new example sketch (FRAMInfo) that interrogates then displays the FRAM address size and capacity.

All existing sketches using this API should still work unmodified, the only relevant API change for them will be that the unsigned 16bit address parameter passed to reads and writes will now be promoted to an unsigned 32bit, this should not produce compiler warnings.

ladyada commented 7 years ago

hiya can you verify it should work 'transparantly' with the original FRAM chip?

pholmes2012 commented 7 years ago

Hi, yes I can verify that it should (and does) work transparently with the original 8K breakout board.

Paul.

On Sun, Nov 26, 2017 at 5:27 PM, ladyada notifications@github.com wrote:

hiya can you verify it should work 'transparantly' with the original FRAM chip?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/adafruit/Adafruit_FRAM_SPI/pull/6#issuecomment-347024555, or mute the thread https://github.com/notifications/unsubscribe-auth/AIAdF_FLYQhPnd2GIy2CcmGwHk8htI6Aks5s6Z-TgaJpZM4QqMK6 .

pholmes2012 commented 6 years ago

Hi, could you let me know if you have decided against taking this PR?

ladyada commented 6 years ago

hiya we're really swamped, will get to this but no ETA :)

deanm1278 commented 6 years ago

hi @pholmes2012, this doesn't seem to be working for me

The FRAM breakout is wired up to an Adafruit Metro as in the learn guide: https://learn.adafruit.com/adafruit-spi-fram-breakout/assembly?view=all#wiring-and-test

And the example MB85RS64V.ino is loaded up.

The example should read the data and then when the board restarts, increment the first byte in the FRAM to show how many times the board has been restarted previously.

The new PR seems to be reading data correctly, but when restarted doesn't increment the first byte, leading me to believe there may be something wrong with the way the new PR is writing data. Please let me know if you have trouble reproducing the problem, and thanks for your contribution :)

pholmes2012 commented 6 years ago

Well spotted Dean, I had managed to break the single byte write, I have just checked in a fix so it works now.

Cheers.

On Tue, Dec 5, 2017 at 6:41 PM, deanm1278 notifications@github.com wrote:

hi @pholmes2012 https://github.com/pholmes2012, this doesn't seem to be working for me

The FRAM breakout is wired up to an Adafruit Metro as in the learn guide: https://learn.adafruit.com/adafruit-spi-fram-breakout/ assembly?view=all#wiring-and-test

And the example MB85RS64V.ino is loaded up.

The example should read the data and then when the board restarts, increment the first byte in the FRAM to show how many times the board has been restarted previously.

The new PR seems to be reading data correctly, but when restarted doesn't increment the first byte, leading me to believe there may be something wrong with the way the new PR is writing data. Please let me know if you have trouble reproducing the problem, and thanks for your contribution :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adafruit/Adafruit_FRAM_SPI/pull/6#issuecomment-349400408, or mute the thread https://github.com/notifications/unsubscribe-auth/AIAdF6RfdKw9AJkdvT8CrZOER09jcXILks5s9Y5KgaJpZM4QqMK6 .