Incorrect Endian Representation in renderIPAddress

[alexanderplin]

• Arduino board: Adafruit Feather HUZZAH ESP8266
• Arduino IDE version (found in Arduino -> About Arduino menu): 1.69
• List the steps to reproduce the problem below (if possible attach a sketch or copy the sketch code in too):

#include <WiFiClient.h>
#include <ESP8266WiFi.h>
#include <Adafruit_GFX.h>
#include <Adafruit_SSD1306.h>
#include <Adafruit_FeatherOLED.h>
#include <Adafruit_FeatherOLED_WiFi.h>
Adafruit_FeatherOLED_WiFi oled = Adafruit_FeatherOLED_WiFi();
void setup(){
    /** connect to WiFi first**/
    oled.setIPAddress((uint32_t)WiFi.localIP());
    oled.refreshIcons();
}
void loop(){
}

On the board we see the IP address reversed. I am guessing this has something to do with the class IPAddress representing IP in Big-Endian, however I believe the Arduino and Adafruit Feather HUZZAH ESP8266 are Little-Endian. In the original library on this repo in Adafruit_FeatherOLED_WiFi.cpp:

void Adafruit_FeatherOLED_WiFi::renderIPAddress ( void )
{
  if (_ipAddressVisible)
  {
    if (_connected)
    {
      setCursor(0,24);
      print((_ipAddress >> 24) & 0xFF, DEC);
      print(".");
      print((_ipAddress >> 16) & 0xFF, DEC);
      print(".");
      print((_ipAddress >> 8) & 0xFF, DEC);
      print(".");
      print(_ipAddress & 0xFF, DEC);
    }
  }
}

This is the correct representation for Big-Endian, but not for Little-Endian. I changed this portion of the code in my local library to:

void Adafruit_FeatherOLED_WiFi::renderIPAddress ( void )
{
  if (_ipAddressVisible)
  {
    if (_connected)
    {
      setCursor(0,24);
      print(_ipAddress & 0xFF, DEC);
      print(".");
      print((_ipAddress >> 8) & 0xFF, DEC);
      print(".");
      print((_ipAddress >> 16) & 0xFF, DEC);
      print(".");
      print((_ipAddress >> 24) & 0xFF, DEC);
    }
  }
}

and now the IP displays correctly on my OLED display. Perhaps this should be changed for the library as well?

[projectarc-co-uk]

Confirmed - this change worked for me too.

Using an Adafruit Huzzah Feather with the OLED Featherwing the IP address obtained from WiFi.localIP() (via ESP8266WiFi.h) displayed in reverse order when passed to setIPAddress(ip).

Changing Adafruit_FeatherOLED_WiFi.cpp as described by alin96 meant the IP addresses displayed correctly.

[Sembazuru]

I can confirm the issue is also there an the ARM platform, specifically Adafruit Feather M0 WiFi - ATSAMD21 + ATWINC1500 using WiFi101 library.

I applied the correction above to my local library and can confirm it works for my platform as well.

FWIW here are my versions:

• Arduino v1.8.1 on Windows
• WiFi101 library v0.12.1
• Adafruit_FeatherOLED library v? (filedate 2016-07-18)
• Arduino SAMD Boards v1.6.12
• Adafruit SAMD Boards v1.0.13