Fix frequency not changing when calling Adafruit_HX8357::begin

adafruit / Adafruit_HX8357_Library

Arduino library for HX8357

43 stars 37 forks source link

Fix frequency not changing when calling Adafruit_HX8357::begin #30

Closed ifullgaz closed 5 years ago

ifullgaz commented 5 years ago

Fix frequency not changing when calling Adafruit_HX8357::begin(uint32_t freq = 0)

Scope: Fix else if statement on line 258 in Adafruit_HX8357::begin from: } else if(HX8357B) { to: } else if(freq == HX8357B) { This change ensures that a request to change the SPI bus frequency will be taken into account.

Known limitations: none

Tests: running and passing

makermelissa commented 5 years ago

Travis failed for the ESP8266 build. Since ESP8266 was updated last week and the cache is about 25 days old, I cleared cache and restarted build. Let's hope it passes.

dsyleixa commented 5 years ago

AFAIK still not fixed for M4 and/or ESP32, see https://github.com/adafruit/Adafruit_HX8357_Library/issues/26