search

adafruit / Adafruit_ILI9341

Library for Adafruit ILI9341 displays
406 stars 281 forks source link

Adding rudimentary hardware vertical scroll API #10

Closed malachib closed 7 years ago

malachib commented 8 years ago

Not implementing the set region API (command 0x33). Hardware scroll will apply to the whole screen by default without the region API call.

pepijndevos commented 8 years ago

How is this used? The flowchart in the datasheet seems very complex compared to your single command.

malachib commented 8 years ago

To summarize, the call changes the start pointer (offset) of where the display renders from. Therefore, memory contents remain unchanged when the screen scrolls. The "y" is the # of pixels to offset from

For example, if scrolling up, the disappearing part from the top reappears at the bottom.

marcmerlin commented 7 years ago

I believe this was added in https://github.com/adafruit/Adafruit_ILI9341/commit/7703b623235b3e63aac3e00b2a1655ffbca28580

and I sent a small cleanup for it in https://github.com/adafruit/Adafruit_ILI9341/pull/26 including demo code for the new ScrollTo method that was added.

marcmerlin commented 7 years ago

@malachib do you mind closing this request if you agree that the current code indeed supports what you wanted?

malachib commented 7 years ago

I apologize I am out of the loop for testing this functionality now. The project I made this change for is defunct. I'd defer to your judgement in this case