adafruit / Adafruit_ILI9341

Library for Adafruit ILI9341 displays
398 stars 278 forks source link

Example code will not compile with latest changes to Adafruit-GFX-Library #45

Closed ardnew closed 5 years ago

ardnew commented 5 years ago

see the most recent commit to the Adafruit-GFX-Library: 1b03380

the tftBusWidth enum value tft8 was changed to tft8bitbus because class Adafruit_SPITFT had a protected anon union containing a named member struct with the same name.

to fix this, it probably would have been safer changing the union member's name instead of the enum, since the union is protected and the enum was visible externally. but as-is, the examples for this library need to update their tft8 references to tft8bitbus. otherwise, currently, none of the following examples will compile: graphicstest_pyportal pyportal_boing touchpaint_pyportal mandelbrot

also the example in Adafruit_ImageReader_Library: PyPortal

ladyada commented 5 years ago

thanks - well, i fixed it the most obvious way i could while making it clear - could you submit a PR for fixes of these examples? that would be rad and if travis passes, we'll merge!

ladyada commented 5 years ago

thanks :)