adafruit / Adafruit_IO_Arduino

Arduino library to access Adafruit IO from WiFi, cellular, and ethernet modules.
Other
208 stars 108 forks source link

Revert "Fix connectErrorString return type for ESP-32 BSP 2.0.8" #166

Closed brentru closed 1 year ago

brentru commented 1 year ago

Reverts adafruit/Adafruit_IO_Arduino#165

Why? The "Arduino Release v2.0.9 based on ESP-IDF v4.4.4" PR https://github.com/espressif/arduino-esp32/pull/8147 is to "revert to the previous definition of FPSTR and F macros". In #165, we patched this breaking change. This pull request is reverting the patch.

brentru commented 1 year ago

Note: This pull request may fail due the Adafruit Arduino MQTT library not having been picked up by the Arduino library manager yet.

AAMQTT version 2.5.4 (https://github.com/adafruit/Adafruit_MQTT_Library/releases/tag/2.5.4) includes a patch for the same issue reverted by this PR.