Closed sabas1080 closed 5 years ago
@sabas1080 This library was tested with Adafruit's airlift hardware using our fork of nina-fw (https://github.com/adafruit/nina-fw).
We could add a #define
for the NINA pin standard. Which nina-fw are you running on the ESP32? The _airlift.h
file implements setPins()
which is part of the adafruit nina-fw fork and may need to be excluded for MKR/WiFi rev.
im cool with using NINA naming. the reason we didnt is because NINA is the trademark name of the module from uBlox and we're using a generic ESP32! i dont want people to get confused
@sabas1080 @ladyada I'll add this to AIOA tomorrow. I'll need to add a #define
for NINA_ACK
into the variant for the AirLift Metro M4 along with a few other boards first. (https://github.com/adafruit/ArduinoCore-samd/blob/master/variants/metro_m4_airlift/variant.h#L131).
Merged into master
and released.
Thanks
Why not maintain the NINA pin name standard?
I've been handling the examples with MKR1010 and Arduino WIFi Rev and I had to make changes
SPIWIFI_ACK -> NINA_ACK ESP32_RESETN -> NINA_RESETN ESP32_GPIO0 -> NINA_GPIO0
Work for me
Thanks!