adafruit / Adafruit_IO_Python

Adafruit IO Python Client Library
Other
223 stars 97 forks source link

Add ability to fetch more than 1000 rows of data #108

Closed kvncp closed 2 years ago

kvncp commented 4 years ago

The current implementation of the data() method only fetches a single page worth of data. This library should implement the pagination specification to allow multiple pages to be fetched.

Some thoughts on API options:

I'd be happy to take a shot at implementation. The first option is probably the easiest to implement and shouldn't take much effort. Open to any thoughts or feedback on an API.

lcmcninch commented 3 years ago

I'd like to take a shot at implementing this and other get feed data query parameters. I'm basically a noob when it comes to contributing to public projects. I suspect I'll have some questions when it comes to code style, how this project implements tests, etc. Is this issue an appropriate forum for that kind of discussion or is there a better place to discuss such topics?

Thanks!

brentru commented 3 years ago

@lcmcninch We have a guide on the Adafruit Learning System about contributing (https://learn.adafruit.com/contribute-to-arduino-with-git-and-github) but it's geared towards our Arduino libraries rather than our Python libraries.

The applicable steps in this guide are:

Tests are run automatically and code is checked with a linter (pylint) when you open a pull request. I'll be happy to review it and answer any questions w.r.t code style/etc in the pull request.