search

adafruit / Adafruit_IO_Python

Adafruit IO Python Client Library
Other
223 stars 97 forks source link

Add ability to create feed within a group #125

Closed brentru closed 3 years ago

brentru commented 3 years ago

API Endpoint: https://io.adafruit.com/api/docs/#create-feed-in-a-group Addresses issues https://github.com/adafruit/Adafruit_IO_Python/issues/104 and https://github.com/adafruit/Adafruit_IO_Python/issues/118

brentru commented 3 years ago

I'm going to merge this in, it passes local and forked unit-tests and will pass on master.

Unit-test failing looks similar to the previous PR, merging into master will authorize the CI script.

Unittest fails to acknowledge the env secrets on PRs (https://github.com/adafruit/Adafruit_IO_Python/pull/125/checks?check_run_id=1590263116#step:7:8) v.s. when the action runs in master.

I believe it's because "secrets are not passed to workflows that are triggered by a pull request from a fork". We would need to work off a branch for future pull-requests. < @dherrada Could you take a look at this/verify that I'm not missing something here?