Closed tekktrik closed 2 years ago
@tekktrik Could you also update the "manual installation" section of the README to add instructions for manually installing Adafruit IO Python after this migration?
https://github.com/adafruit/Adafruit_IO_Python#manual-installation
Yup! PR already includes the updated manual installation command! Additional change is that CI takes care of updating version strings, by the way. Manual installs will be version 0.0.0
.
@brentru let me know if any additional changes are needed
Hey! What do we think about using the build backend hatchling
(of which I am a maintainer in the PyPA) as that is now the default in the official Python packaging tutorial. Hatchling is available on all the major distribution channels such as Debian, Fedora, Arch Linux, conda-forge, Nixpkgs, Alpine Linux, FreeBSD, Gentoo Linux, MacPorts, OpenEmbedded, Spack, etc.
My personal vote would be to transition to a setuptools
backend to match the few hundred libraries we just migrated to be that so they all match. If we want to transition all of these in the future that's worth exploring, but probably out of scope for this PR, which is just to move away from setup.py
.
@brentru I think I might have fixed the previous issue, so just need approval for the CI again
@brentru is anything still needed before CI run?
@brentru is this good to run?
I think I'll continue to touch this up when I have a little more time, but closing in the meantime.
Changes for migrating from
setup.py
topyproject.toml
. Changes include:setup.py
topyproject.toml
ez_setup.py
becausepyproject.toml
handles downloading build dependencies (setuptools
)ez_setup
as a moduleResolves #143