adafruit / Adafruit_IO_Python

Adafruit IO Python Client Library
Other
223 stars 97 forks source link

Migrate to pyproject.toml #145

Closed tekktrik closed 2 years ago

tekktrik commented 2 years ago

Changes for migrating from setup.py to pyproject.toml. Changes include:

Resolves #143

brentru commented 2 years ago

@tekktrik Could you also update the "manual installation" section of the README to add instructions for manually installing Adafruit IO Python after this migration?

https://github.com/adafruit/Adafruit_IO_Python#manual-installation

tekktrik commented 2 years ago

Yup! PR already includes the updated manual installation command! Additional change is that CI takes care of updating version strings, by the way. Manual installs will be version 0.0.0.

tekktrik commented 2 years ago

@brentru let me know if any additional changes are needed

ofek commented 2 years ago

Hey! What do we think about using the build backend hatchling (of which I am a maintainer in the PyPA) as that is now the default in the official Python packaging tutorial. Hatchling is available on all the major distribution channels such as Debian, Fedora, Arch Linux, conda-forge, Nixpkgs, Alpine Linux, FreeBSD, Gentoo Linux, MacPorts, OpenEmbedded, Spack, etc.

tekktrik commented 2 years ago

My personal vote would be to transition to a setuptools backend to match the few hundred libraries we just migrated to be that so they all match. If we want to transition all of these in the future that's worth exploring, but probably out of scope for this PR, which is just to move away from setup.py.

tekktrik commented 2 years ago

@brentru I think I might have fixed the previous issue, so just need approval for the CI again

tekktrik commented 2 years ago

@brentru is anything still needed before CI run?

tekktrik commented 2 years ago

@brentru is this good to run?

tekktrik commented 2 years ago

I think I'll continue to touch this up when I have a little more time, but closing in the meantime.