search

adafruit / Adafruit_IO_Python

Adafruit IO Python Client Library
Other
225 stars 99 forks source link

Paho v1 compatibility #153

Closed tyeth closed 7 months ago

tyeth commented 8 months ago

This PR adds the API compatibility v1 argument to the client. It also uses paho errors instead of the MQTT_ERRORS collection from errors.py They will be left for legacy reasons, but they don't match all the available errors so should not be relied upon.

Closes #152

tyeth commented 8 months ago

Tagging @brentru for review

brentru commented 8 months ago

@tyeth do you need a re-review?

tyeth commented 8 months ago

@tyeth do you need a re-review?

@brentru Yes please 🙏

tyeth commented 8 months ago

For some reason it wasn't showing me the latest commits when viewing feedback comments, but manually viewing all changes I've verified the errors are deleted and conversations are resolved @brentru .

brentru commented 7 months ago

@tyeth Merged,could you create a new release and close out https://github.com/adafruit/Adafruit_IO_Python/issues/152#issuecomment-1986871706?