search

adafruit / Adafruit_IO_Python

Adafruit IO Python Client Library
Other
225 stars 99 forks source link

Add Timezone support to `receive_time` and update tests (adjusted-time-failure) #158

Closed tyeth closed 1 month ago

tyeth commented 1 month ago

This PR is to add the timezone argument to receive_time, allowing users to request specific timezones rather than rely on autodetection.

This also reduces the flakiness of the test test_time_data which would intermittently fail depending if is_DST was 0 or 1 when the time struct was returned from the time service (GitHub runners are UTC and so is_DST=1 would fail when time struct passed to time.mktime)

tyeth commented 1 month ago

Hey @brentru, this is ready for review. We had a failure on CI due to time.mktime not accepting is_DST=1 for the github runners timezone of UTC.

This adds UTC timezone to the test's request, along with adding support for requesting the timezone via receive_time.