Conflict with feather SPI flash library

adafruit / Adafruit_LED_Backpack

Adafruit LED Backpack Library for our various LED backpacks.

MIT License

301 stars 192 forks source link

Conflict with feather SPI flash library #45

Closed ChrisInSingapore closed 3 years ago

ChrisInSingapore commented 5 years ago

Both this library and the other feather library SPIFlash define and use BYTE. It would be good to use a different name in this library. The issue is fully described here: https://forums.adafruit.com/viewtopic.php?f=57&t=143261

caternuson commented 5 years ago

Conflict between here: https://github.com/adafruit/Adafruit_LED_Backpack/blob/master/Adafruit_LEDBackpack.h#L135 and here: https://github.com/adafruit/Adafruit_SPIFlash/blob/master/utility/diskio.h#L15

caternuson commented 3 years ago

Hopefully fixed with #63