Dependencies are too broad on PalatformIO

adafruit / Adafruit_LED_Backpack

Adafruit LED Backpack Library for our various LED backpacks.

MIT License

301 stars 192 forks source link

Dependencies are too broad on PalatformIO #52

Closed 101100 closed 4 years ago

101100 commented 4 years ago

The dependencies of the library are too broad. I tried using the library in a PlatformIO project on a Huzzah32 and it would not compile due to the WaveHC dependency that the library does not really need. Even if it did compile, it takes a really long time due to all of the unneeded dependencies.

Specifically here:

https://github.com/adafruit/Adafruit_LED_Backpack/blob/8ac14abaf77beab2c92b1729ab8404c917653ed2/library.properties#L9

this should only be:

depends=Adafruit GFX Library

ladyada commented 4 years ago

hihi i think this is fixed in the latest version of PlatformIO that @ivankravets just pushed here https://github.com/platformio/platformio-core/issues/3607