adafruit / Adafruit_LSM6DS

Arduino library for LSM6DS
Other
47 stars 39 forks source link

github-actions: do the more expensive tests last #35

Closed eringerli closed 2 years ago

eringerli commented 2 years ago

In my experience, the clang-format and doxygen tests failed the most in my PRs. These are also the least expensive tests, they execute in the range of seconds, but are last checked. You can reasonally expect that the code compiles, but documentation and code formating are hit and miss, especially when different people have different editors and workflows. This saves a lot of execution time on github and gives the users more immediate feedback: 10 out of 13 minutes are the compilation on different platforms you have to wait for until the it fails on a trivial formating or documentation error

Here is a typical log of the workflow: Screenshot_20220429_085028

Perhaps it is further possible to optimize that by only installing clang-format and doxygen and executing these test before installing platformio (in pre-install), which should shave off some more time. I will look into this in the repo adafruit/ci-arduino, but for the time beeing, please consider accepting this PR.

eringerli commented 2 years ago

I have submitted a PR in adafruit/ci-arduino: https://github.com/adafruit/ci-arduino/pull/134