search

adafruit / Adafruit_Learning_System_Guides

Programs and scripts to display "inline" in Adafruit Learning System guides
MIT License
1.01k stars 770 forks source link

Copyright and License notices on MACROPAD example? #1847

Closed rpavlik closed 3 years ago

rpavlik commented 3 years ago

The MacroPad example is great to customize and share, however, I hesitate to do so without a clear copyright and license notice. I see that some other samples have SPDX tags which would be great. For my own macro configs I'm using CC0-1.0. I'd be happy with pretty much any permissive license you already use to be placed on https://github.com/adafruit/Adafruit_Learning_System_Guides/blob/main/Macropad_Hotkeys/code.py and associated files

I use the https://reuse.software tool to ensure (in CI) that my projects all have complete and correct copyright/licensing statements for each file. I think maybe some of your circuitpython libraries do too? Might be harder in this repo because of the binary assets and the desire to make small bundles, but steps in that direction would be appreciated.

Thanks for your great resources (and hardware!)

TheKitty commented 3 years ago

I agree with @rpavlik that labeling has been inconsistent and Adafruit should establish a methodology for license information.

rpavlik commented 3 years ago

It's actually pretty good on the library repositories, I think: I'm pretty sure at least some have the reuse CI check enabled. It's just this one, which ironically is the one most likely to be modified. (Many of my Adabox project downloads do actually have spdx tags for the code too, though less often for the assets, this macro pad one is the first in a while that I remember missing that data.) Thanks for looking into it!

rpavlik commented 3 years ago

It looks like the file I linked is still missing notices?

TheKitty commented 3 years ago

We have just started a project to go through the entire Learn repo and add license information. It'll take a bit of time, though.

On Thu, Sep 30, 2021 at 12:25 PM Ryan A. Pavlik @.***> wrote:

It looks like the file I linked is still missing notices?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/adafruit/Adafruit_Learning_System_Guides/issues/1847#issuecomment-931476364, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOSY4H2K7PKQBEJQ7UM3U3UESFRLANCNFSM5E56J34A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Anne Barela (she/her) Engineer, Adafruit Industries @.***

rpavlik commented 3 years ago

Oh awesome, thanks. No worries!