adafruit / Adafruit_LvGL_Glue

“Glue” library between LittlevGL and Adafruit GFX (SPITFT)
Other
35 stars 14 forks source link

CI builds failing due to dependency issues #19

Open dhalbert opened 1 year ago

dhalbert commented 1 year ago
arduino-cli lib install "lvgl (=8.2.0)" > /dev/null
attempt 1 failed, 2 retry left
attempt 2 failed, 1 retry left
attempt 3 failed, 0 retry left
FAILED to install dependency lvgl (=8.2.0)

See this https://github.com/espressif/esp-idf/issues/8495 and maybe newer stuff

caternuson commented 1 year ago

This is unfortunately necessary. There's currently an apparent disparity in the version specification syntax between arduino-cli and arduino-lint. Passing an arduino-lint check is needed for the library to be published into the Arduino Library Manager. So that syntax is being used for that reason. As a result, arduino-cli checks will fail.

See also: https://github.com/adafruit/Adafruit_LvGL_Glue/pull/18

ladyada commented 1 year ago

@caternuson do we want to manually install the library then... or change ci-arduino's pass/fail critereon?

caternuson commented 1 year ago

I think we're stuck with the current syntax in library.properties for the sake of Arduino Library Manager. So even if the library were manually installed, arduino-cli would probably still balk trying to parse the version syntax.

Crazy hack idea - how about adding a step to this repo's CI, before the pre-install step, that does something like a sed command to directly modify library.properties to change the syntax to what arduino-cli wants? Like a basic search/replace.

caternuson commented 1 year ago

Ex:

sed -i 's/lvgl (=8.2.0)/lvgl@8.2.0/' library.properties

but with whatever $(REPO_FOLDER) prefixes might also be needed

caternuson commented 1 year ago

@dhalbert Was the ESP IDF link just another example of a similar issue? Or is there more tie in from that issue thread that applies here?