Do not publish NaN floats

adafruit / Adafruit_MQTT_Library

Arduino library for MQTT support

MIT License

566 stars 292 forks source link

Do not publish NaN floats #58

Open ndoo opened 7 years ago

ndoo commented 7 years ago

Arduino board: Adafruit Feather M0 WiFi
Arduino IDE version (found in Arduino -> About Arduino menu): 1.6.10
List the steps to reproduce the problem below (if possible attach a sketch or copy the sketch code in too): LIST REPRO STEPS BELOW
Create a NaN float (e.g. divide-by-zero)
Pass it to a Adafruit_MQTT_Publish.publish((float) f)
Literal "NaN" characters published to float (due to munching by dtostrf)

PR opened: #57

ndoo commented 7 years ago

I’ll keep this out of the issue text above as it could be seen as a personal preference - but publishing characters ("NaN") to the feed adds additional input validation requirements on subscribers which may (naively) atof() subscription output.