search

adafruit / Adafruit_Protomatter

RGB matrix library for Arduino
70 stars 24 forks source link

core: _PM_resume: put address pins in known state #25

Closed jepler closed 4 years ago

jepler commented 4 years ago

Before this, using the "brightness" property in CircuitPython would cause the display to become jumbled. Reproducer script for matrixportal:

import sys
import time
import random
from adafruit_matrixportal.matrix import Matrix

MATRIX = Matrix(bit_depth=1)
DISPLAY = MATRIX.display

sys.stdout.write("JUMBLED\nTEXT")
time.sleep(3)

while True:
    DISPLAY.brightness = 0
    DISPLAY.brightness = 1
    time.sleep(random.random())

After the fix there is only a slight flicker due to the time the display spends with zero brightness.

Thanks to @firepixie for the report!

jepler commented 4 years ago 
  File "/opt/hostedtoolcache/Python/3.9.0/x64/lib/python3.9/site-packages/nordicsemi/dfu/intelhex/__init__.py", line 373, in _tobinstr_really
    return asstr(self._tobinarray_really(start, end, pad, size).tostring())
AttributeError: 'array.array' object has no attribute 'tostring'

This is a problem caused by python3.9 removing the tostring method. It can be fixed by setting python to version 3.8 in the CI script. I can file a PR to do this if you need me to.

jepler commented 4 years ago

Erin reports privately that a uf2 I provided her fixed the problem.