adafruit / Adafruit_Protomatter

RGB matrix library for Arduino
57 stars 20 forks source link

RP2040 Arduino support #43

Closed PaintYourDragon closed 2 years ago

PaintYourDragon commented 2 years ago

Arduino RP2040 support enabled (via Philhower core) and 3 examples enabled (Feather-based ones that aren’t tied to board-specific features). Tested on a few matrix sizes & board F_CPU settings.

The NOP pulse timing for the default 125 MHz has changed slightly — from 2 NOPs low, 0 high, to 1 low, 1 high — else was seeing flicker. However, CircuitPython was apparently doing okay with the 2/0 setting. Since this code base is shared, it’s perhaps best to test the 1/1 timing there, and use this if it works in both places, otherwise move the _PM_clockHoldLow and _PM_clockHoldHigh macro definitions into the platform-specific sections of rp2040.h.

rp2040 added to architectures in library.properties, but version number is not bumped yet. Easily done via Github web UI if/when this is approved & merged.

jepler commented 2 years ago

I did test that it builds, just didn't run it, let alone drive a panel with it.

PaintYourDragon commented 2 years ago

Thanks for looking through it. Merged and bumped the release number. So…if any issues come up in the near future…might be my NOP juggling.