search

adafruit / Adafruit_Protomatter

RGB matrix library for Arduino
66 stars 23 forks source link

Updates to support esp-idf v5.0 on CircuitPython #50

Closed microdev1 closed 2 years ago

microdev1 commented 2 years ago

I believe, I accidentally removed @PaintYourDragon from review.

do you have anything you can test this with (an RGB Matrix, etc.)?

I can't test as I don't have the hardware.

dhalbert commented 2 years ago

Thanks for the quick test @PaintYourDragon!

PaintYourDragon commented 2 years ago

Oh also — is matrix support for both S2 and S3 canonically in CircuitPython at this point? I have a to-do elsewhere that could be closed out in that case. Thx!

dhalbert commented 2 years ago

Oh also — is matrix support for both S2 and S3 canonically in CircuitPython at this point? I have a to-do elsewhere that could be closed out in that case. Thx!

It is turned off for plain ESP32 but otherwise is on for everything else: https://github.com/adafruit/circuitpython/blob/b6f67be3e2c58d3780e2a1bc3801ac5a43f19d4d/ports/espressif/mpconfigport.mk#L40

I'm not actually sure why it's turned off for plain ESP32. Is that your doing? Plain ESP32 has various IDF differences.

PaintYourDragon commented 2 years ago

Not my doing, I’ve tended to stick to the Arduino side of the code. I could speculate that it might be too much for the OG ESP32 (since the code there is all brute force bitbang-y, no peripherals/DMA), but not sure.

OR…possibly it was meant to be disabled for the C3 and something went in the wrong place. I don’t think there’s enough GPIO on the C3 to run a matrix, and even if there was, looks like the code’s empty for that one, like it might’ve just been a placeholder or something put there to pass CI.

PaintYourDragon commented 2 years ago

Any relationship between this and PR https://github.com/adafruit/Adafruit_Protomatter/pull/47? Looks like changes from the latter have already been incorporated and it can be closed? Not sure.

jepler commented 2 years ago

You can close up #47, because I'm not likely to get back to testing on that microcontroller anytime soon. When I last tested on circuitpython it didn't work or else my testing setup was wrong