search

adafruit / Adafruit_Python_PlatformDetect

MIT License
58 stars 233 forks source link

ODROID-M1: Remove RK3568B2 and Use RK3568 instead #331

Closed how2flow closed 9 months ago

how2flow commented 9 months ago

The prefixes for the 'compatible' property of rk3568 are all patterns of the form 'rockchip, rk3568-*'. 'rockchip, rk3568b2' does not seem appropriate.

makermelissa commented 9 months ago

Hi, sorry about the delay. There was some talk about changing boards from RK3588 to RK3588S and I misread the number on this.

cybershoe commented 9 months ago

Looks like this is breaking adafruit_blinka.microcontroller.pin, it's still referencing the RK3568B2 constant from constants.chips

>>> import microcontroller
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/adam/src/minihass/venv/lib/python3.10/site-packages/microcontroller/__init__.py", line 16, in <module>
    from microcontroller import pin  # pylint: disable=unused-import
  File "/home/adam/src/minihass/venv/lib/python3.10/site-packages/microcontroller/pin.py", line 117, in <module>
    elif chip_id == ap_chip.RK3568B2:
AttributeError: module 'adafruit_platformdetect.constants.chips' has no attribute 'RK3568B2'. Did you mean: 'RK3568'?