search

adafruit / Adafruit_Python_PlatformDetect

MIT License
58 stars 233 forks source link

#331 breaks microcontroller package #332

Closed cybershoe closed 9 months ago

cybershoe commented 9 months ago

PR #331 removes a constant relied on by adafruit_blinka.microcontroller:

Steps to reproduce: import microcontroller

>>> import microcontroller
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/adam/src/minihass/venv/lib/python3.10/site-packages/microcontroller/__init__.py", line 16, in <module>
    from microcontroller import pin  # pylint: disable=unused-import
  File "/home/adam/src/minihass/venv/lib/python3.10/site-packages/microcontroller/pin.py", line 117, in <module>
    elif chip_id == ap_chip.RK3568B2:
AttributeError: module 'adafruit_platformdetect.constants.chips' has no attribute 'RK3568B2'. Did you mean: 'RK3568'?
makermelissa commented 9 months ago

Once https://github.com/adafruit/Adafruit_Blinka/pull/750 is updated and merged, it should work again. Unfortunately with the 2 repo system, it has to be merged in this one and released before the other one can pass the test. In rare instances like this, it can leave it in a non-working state. My suggestion would be to install PlatformDetect 3.56.0 until it's merged.

cybershoe commented 9 months ago

My knack for always having the worst timing strikes again... I'll just comment it out for now and wait for the other merge to finish. Looks like it's just failing on formatting.

makermelissa commented 9 months ago

Sounds good. Yeah, I think they just need to add a description for what the function does.

makermelissa commented 9 months ago

The issue should be fixed now.