adafruit / Adafruit_SH110x

Arduino library for SH110x based monochrome OLEDs
Other
67 stars 30 forks source link

Documentation copy/paste error #2

Closed benzvan closed 3 years ago

benzvan commented 3 years ago

In the README.md of this project I see:

Preferred installation method is to use the Arduino IDE Library Manager. To download the source from Github instead, click "Clone or download" above, then "Download ZIP." After uncompressing, rename the resulting folder Adafruit_SSD1306. Check that the Adafruit_SSD1306 folder contains Adafruit_SSD1306.cpp and Adafruit_SSD1306.h.

But I think that is a holdover from the SSD1306 project and not correct for this SH110x project

ladyada commented 3 years ago

could be! can you submit a PR with documentation changes?

benzvan commented 3 years ago

I'd be more than happy to. Should I just s/SSD1306/SH110X/g in the README?

I haven't been able to get it to work on my Photon since it's so different so I can't validate this is correct. I happened to notice this when I was digging into it.

ladyada commented 3 years ago

yep :)

benzvan commented 3 years ago

https://github.com/adafruit/Adafruit_SH110x/pull/3