search

adafruit / Adafruit_SH110x

Arduino library for SH110x based monochrome OLEDs
Other
63 stars 29 forks source link

Arduino_SH110X is an abstract class #4

Closed pinecat closed 3 years ago

pinecat commented 3 years ago

Hello,

I've found a code issue with this library. It is not a fatal issue, as it does compile and work, however it does a couple of errors:

  1. object of abstract class type "Adafruit_SH110X" is not allowed: -- pure virtual function "Print::write(uint8_t)" has no overrider Capture
  2. a cast to abstract class "Adafruit_SH110X" is not allowed: -- pure virtual function "Print::write(uint8_t)" has no overrider Capture2

The above lines are from the example code for the Adafruit 128x64 OLED FeatherWing, running on an Adafruit Feather HUZZAH ESP8266: https://learn.adafruit.com/adafruit-128x64-oled-featherwing/arduino-code.

I've been able to reproduce these errors on two platforms: Windows 10 and MacOS. I am using Microsoft VSCode.

MacOS 10.15.6 Catalina VSCode 1.55.0 VSCode Extension: Arduino 0.4.0 https://marketplace.visualstudio.com/items?itemName=vsciot-vscode.vscode-arduino VSCode Extension: C/C++ 1.3.0-insiders3 https://marketplace.visualstudio.com/items?itemName=ms-vscode.cpptools Arduino IDE 1.8.13

Windows 10 20H2 VSCode 1.55.0 VSCode Extension: Arduino 0.4.0 https://marketplace.visualstudio.com/items?itemName=vsciot-vscode.vscode-arduino VSCode Extension: C/C++ 1.3.0-insiders3 https://marketplace.visualstudio.com/items?itemName=ms-vscode.cpptools Arduino IDE 1.8.13

Again, the code still compiles and runs fine, but these errors appear nonetheless.

Thank you!

pinecat commented 3 years ago

Library was refactored. This issue does not occur in the new codebase.